-
Notifications
You must be signed in to change notification settings - Fork 2.9k
ibrha - first commit #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
ibrha - first commit #1121
Conversation
plha-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job for these first chapters and for using the proper git title convention !
a few small comments :
- We try to always leave an empty line at the end of every file.
If you are using vscode there is an option to automatically do it which is called Insert Final Newline. - the convention is to have two blank lines before a class definition
plha-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job on the code, the commit titles and most of the styling.
A few comments :
- on your last commit title, the convention is to always write the name of the module in lower case.
- a few styling mistake written in the Style runbot
568ec37 to
80951a9
Compare
plha-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, good job !
08cbc06 to
d3364de
Compare
This module provides managing real estate advertisements. It introduces the \`estate.property\` model with fields for: - Property descriptions (name, description, postcode, etc.) - Pricing (expected and selling price) - Physical characteristics (bedrooms, living area, facades) - Garden information (area and orientation)
adds the initial UI for the estate module: - Add action and menus in XML files. - Add new fields and modify the existing fields. - Update manifest to include the new XML files.
Adds multiple ui views (list, form, search) 1) adding missing EOLs 2) updating fields in estate.property model
- Define 'estate.property.offer' and 'estate.property.tag' and 'estate.property.type' models. - Add One2many relationship for offers and Many2many for tags, types on properties. - Update property views with a notebook containing 'Offers' and 'Other Info' tabs. - Add 'salesman' and 'buyer' fields to properties other info's section.
- Implement 'total_area' and 'best_price' computed fields on estate.property. - Add 'validity' and 'deadline_date' to estate.property.offer with compute and inverse logic. - Add an onchange for the 'garden' field to update garden area and orientation automatically. - Fix deletion error when deleting a property by adding 'ondelete="cascade"' to 'property_id' in the estate.property.offer model.
…e' on offers - Add the buttons ‘Cancel’ and ‘Sold’ to the estate.property - Add the buttons ‘Accept’ and ‘Refuse’ to the estate.property.offer - set the buyer and the selling price for the property when offer is accepted
- Add SQL constraints for `estate.property` selling price and expected price - Add SQL constraints for `estate.property.offer` price - Add SQL constraints for the uniqueness of `estate.property.tag` and `estate.property.type` names - Add Python constraints for checking if the selling_price is at least 90% of the expected price
- Add 'offer_count' stat button and notebook list to Property Types form. - Enhance property list view with status-based decorations (success, muted, bold). - Create dedicated 'Property Offers' view and configuration menu. - Add visibility tokens (invisible) and statusbar widget for better form flow. - Support tag coloring (Many2many) and 'Available' default search filter.
- Add option for users to view assigned properties - Add constraints to make new offers only with price higher than other existing ones - Inherit from `res.user` form view to add assigned properties page - Delete property shouldn't work on 'sold' or 'cancelled' properties
…e modules - Add a new module `estate.account` to be able to create invoices when selling a property
d3364de to
b65426a
Compare
plha-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job for the past two weeks ! all the best in your new team !
Thank you for your help for those two weeks and for all the discussions, questions :) |

No description provided.